"All that is gold does not glitter"

The original was actually Shakespeare: all that glisters is not gold, but that needn't concern us here.

OP has simply misparsed the sentence - it actually means "Not everything that is gold glitters" (which is to say, "There are some things which are gold that don't glitter").

You can always Google "every x is not y" for more discussion of why this type of construction should be treated with caution. As it happens, I already knew what it means in this particular case (and I knew it was originally glisters), but I think the bottom line is the statement is inherently ambiguous, so you have to go for the interpretation that makes most sense in context.

Tolkien experimented with several variants of the "quirky inversion" of Shakespeare's original before finally settling on the The Riddle of Strider version (that appears twice in The Fellowship of the Ring). But I quite like this somewhat more "pithy" earlier draft...

All that is gold does not glitter;
all that is long does not last;
All that is old does not wither;
not all that is over is past.

(I don't know whether the punctuation/capitalisation there was actually what Tolkien wrote).

Shakespeare's line is the best known example of this general phenomenon where a universal quantifier scoping over negation gives a counterintuitive meaning. The expected meaning of:

All that glisters is not gold.

Would be:

For each thing that glisters, it is not gold.

Instead, the meaning to be understood is:

Not everything that glisters is gold.

See Laurence Horn's excellent discussion of this phenomenon in Chapter 4 of his book A Natural History of Negation. (University of Chicago Press, 1989). Other examples Horn draws attention to are (p.226--7):

All things are lawful unto me, but all things are not expedient. (1Cor.6:12)
Every one cannot make music. (Walton)
Tout Ie monde n' est past fait pour l' art. (Rolland)
Thank heaven, all scholars are not like this. (Richardson)
All is not lost. (Milton, Shelley)
Each man kills the thing he loves/Yet each man does not die. (Wilde)

Horn points out, even more interestingly, that while the English can be paraphrased into the intuitive:

Not all that glitters is gold.

In French, however, the "counterintuitive" version:

Tout ce qui reluit n'est pas or.

does not have an "intuitive" grammatical paraphrase. The following is ungrammatical in French:

*Pas tout ce qui reluit est or.