Rails 3: "field-with-errors" wrapper changes the page appearance. How to avoid this?
You should override ActionView::Base.field_error_proc
. It's currently defined as this within ActionView::Base
:
@@field_error_proc = Proc.new{ |html_tag, instance|
"<div class=\"field_with_errors\">#{html_tag}</div>".html_safe
}
You can override it by putting this in your application's class inside config/application.rb
:
config.action_view.field_error_proc = Proc.new { |html_tag, instance|
html_tag
}
Restart rails server for this change to take effect.
The visual difference you are seeing is happening because the div
element is a block element. Add this style to your CSS file to make it behave like an inline element:
.field_with_errors { display: inline; }
I currently use this solution, placed in an initializer:
ActionView::Base.field_error_proc = Proc.new do |html_tag, instance|
class_attr_index = html_tag.index 'class="'
if class_attr_index
html_tag.insert class_attr_index+7, 'error '
else
html_tag.insert html_tag.index('>'), ' class="error"'
end
end
This allows me to merely add a class name to the appropriate tag, without creating additional elements.
The extra code is being added by ActionView::Base.field_error_proc
. If you're not using field_with_errors
to style your form, you can override it in application.rb
:
config.action_view.field_error_proc = Proc.new { |html_tag, instance| html_tag.html_safe }
Alternatively, you can change it to something that suits your UI:
config.action_view.field_error_proc = Proc.new { |html_tag, instance| "<span class='field_with_errors'>#{html_tag}</span>".html_safe }
I am working with Rails 5 and Materialize-Sass and I am getting some issues with the default behavior from Rails to treat failed field validations as in the image below and it was because of the extra div
added to the input fields where validation failed.
Working with @Phobetron answer and modifying Hugo Demiglio's answer too. I made some adjustments to those blocks of code and I get something working well in the following cases:
- If both
input
andlabel
has their ownclass
attribute anywhere<input type="my-field" class="control">
<label class="active" for="...">My field</label>
- If the
input
orlabel
tags does not have aclass
attribute<input type="my-field">
<label for="...">My field</label>
- if the
label
tag has another tag inside with theclass attribute
<label for="..."><i class="icon-name"></i>My field</label>
In all those cases the error
class will be added to the existing classes in the class
attribute if exist or it will be created if it is not present in the label or input tags.
ActionView::Base.field_error_proc = Proc.new do |html_tag, instance|
class_attr_index = html_tag.index('class="')
first_tag_end_index = html_tag.index('>')
# Just to inspect variables in the console
puts '😎 ' * 50
pp(html_tag)
pp(class_attr_index)
pp(first_tag_end_index)
if class_attr_index.nil? || class_attr_index > first_tag_end_index
html_tag.insert(first_tag_end_index, ' class="error"')
else
html_tag.insert(class_attr_index + 7, 'error ')
end
# Just to see resulting tag in the console
pp(html_tag)
end
I hope it could be useful for someone with the same conditions like me.