C# Winform ProgressBar and BackgroundWorker

One problem is that you're sleeping for 30 seconds. Normally you'd call ReportProgress at various points within your long-running task. So to demonstrate this, you might want to change your code to sleep for 1 second, but 30 times - calling ReportProgress each time it finishes a sleep.

Another problem is that you're showing your ProgressForm from the background thread. You should start it in the UI thread, but hook the background worker's ProgressChanged event to it. Then when the background worker reports progress, the progress form will be updated.

ReportProgress is the method which you'll have to call in your 'working' method. This method will raise the 'ProgressChanged' event.

In your form, you can attach an eventhandler to the ProgressChanged event. Inside that eventhandler, you can change the position of the progressbar. You can also attach an eventhandler to the RunWorkerCompleted event, and inside that eventhandler, you can close the form which contains the progressbar.

It should be noted you need to set

backgroundWorker1.WorkerReportsProgress = true;

if you want the background worker to raise the ProgressChanged event and

backgroundWorker1.WorkerSupportsCancellation = true;

if you wish to be able to cancel the worker thread.

As the others have said, run the f.ShowDialog() in your UI thread and use ProgressChanged to update the ProgressWindow.

To get the ProgressForm to self close, in backgroundWorker1_RunWorkerCompleted, call f.Close(); This means the long operation has completed and we can close the window.