python try:except:finally

Solution 1:

You shouldn't be writing to the file in the finally block as any exceptions raised there will not be caught by the except block.

The except block executes if there is an exception raised by the try block. The finally block always executes whatever happens.

Also, there shouldn't be any need for initializing the file variable to none.

The use of return in the except block will not skip the finally block. By its very nature it cannot be skipped, that's why you want to put your "clean-up" code in there (i.e. closing files).

So, if you want to use try:except:finally, you should be doing something like this:

try:
    f = open("file", "w")
    try:
        f.write('Hello World!')
    finally:
        f.close()
except IOError:
    print 'oops!'

A much cleaner way of doing this is using the with statement:

try:
    with open("output", "w") as outfile:
        outfile.write('Hello World')
except IOError:
    print 'oops!'

Solution 2:

If the file is not opened, the line file = open(filePath, 'w') fails, so nothing gets assigned to file.

Then, the except clause runs, but nothing is in file, so file.close() fails.

The finally clause always runs, even if there was an exception. And since file is still None you get another exception.

You want an else clause instead of finally for things that only happen if there was no exception.

    try:
        file = open(filePath, 'w')
    except IOError:
        msg = "Unable to create file on disk."
        return
    else:
        file.write("Hello World!")
        file.close()

Why the else? The Python docs say:

The use of the else clause is better than adding additional code to the try clause because it avoids accidentally catching an exception that wasn’t raised by the code being protected by the try ... except statement.

In other words, this won't catch an IOError from the write or close calls. Which is good, because then reason woudn't have been “Unable to create file on disk.” – it would have been a different error, one that your code wasn't prepared for. It's a good idea not to try to handle such errors.