Is it bad form to call a classmethod as a method from an instance?
Solution 1:
If you are tempted to call a class method from an instance you probably don't need a class method.
In the example you gave a static method would be more appropriate precisely because of your last remark (no self/cls interaction).
class C(object):
@staticmethod
def f(x):
return x + x
this way it's "good form" to do both
c = C()
c.f(2)
and
C.f(2)
Solution 2:
I don't recall using a classmethod like this from outside the class, but it is certainly ok for an instance method to call a classmethod on itself (e.g. self.foo()
where foo
is a classmethod). This makes sure that inheritance acts as expected, and will call .foo()
in the right subclass instead of the base class.
Solution 3:
It's mainly just confusing looking. If I were using your class and saw this, it would make me wonder what other surprises are in there, it just looks like bad design.
Is there a reason it's not just a staticmethod?
Solution 4:
C.f()
is clearer than c_instance.f()
, and c_instance.__class__.f()
is just ugly. Since clarity and beauty are dearly loved characteristics in the python community, I'd tend to say that C.f() is the best route.
Is there any particular reason you even want to call it in either of the other ways?