On the definition of local compactness

The answer to your question $1$ is no. Consider the set $U:=(0,1)\subset \mathbb R$ equipped with the usual topology. The collection of open sets $\{(1/n,1-1/n)\}_{n\in\mathbb N}$ covers $U$, but $U$ is not in the collection. $U$ is definitely not compact.