If a smoky potion is diluted, does it still have the same chance of producing a djinni as an undiluted smoky potion?

Yes, the dilution status has no effect at all on how the potion works, with the exception of booze and fruit juice giving less nutrition. Alchemizing potions to get smoky to quaff for wishes is just as effective as actually finding the undiluted smoky potions.