Why is my attempt at night vision goggles not working?

Solution 1:

As MrLemon has pointed out in the comments, there is an error in your fourth step, where the command is:

effect @a[score_nightVision_min:1] 16 30 0 true

You have to replace the colon ( : ) with an equals sign ( = ) for that part to work.