fgetc, checking EOF
Solution 1:
You can't cast the return value to char because the return value could be EOF, and EOF value is system-dependent and is unequal to any valid character code. link
Usually it is -1 but you should not assume that.
Check this great answer from the c-faq-site:
Two failure modes are possible if, as in the fragment above, getchar's return value is assigned to a char.
If type char is signed, and if EOF is defined (as is usual) as -1, the character with the decimal value 255 ('\377' or '\xff' in C) will be sign-extended and will compare equal to EOF, prematurely terminating the input. (assuming 8 bits char).
If type char is unsigned, an actual EOF value will be truncated (by having its higher-order bits discarded, probably resulting in 255 or 0xff) and will not be recognized as EOF, resulting in effectively infinite input.
Hope it helps!
Edited: (added the @FatalError comment on this answer, this is explained on the c-faq site but this looks more clear to me)
"If you cast it to char then EOF takes the same value as some valid character and hence becomes indistinguishable from that character. That alone should be enough justification to not make the result a char" @FatalError comment.
Solution 2:
There are two possibilities when you assign the value to a char before comparing with EOF:
-
charis a signed value. In that case, there is a legitimate character (often ÿ, SMALL LATIN LETTER Y WITH DIAERESIS, U+00FF) that will be misinterpreted as EOF. -
charis an unsigned value. In that case, EOF will be translated to 0xFF, and then promoted tointas a positive value, which will never compare equal to EOF which is a negative value.
Either way, the program is going to misbehave some of the time.
There is (or, more accurately, used to be) a chance of a compiler bug such that the assignment occurred correctly but the assigned value was not used for the comparison. That would lead to the code appearing to work OK even when it is not. Fortunately, that is unlikely to be a problem found in a modern compiler.