Samba server icon on the mac is still the ugly CRT monitor despite the seemingly correct settings

Solution 1:

I figured it out:

dnf -y install avahi
systemctl enable --now avahi-daemon.service
systemctl start avahi-daemon

also restart Samba:

systemctl restart smb
systemctl restart nmb

and you're good to go - a beautiful icon will appear instead of the ugly CRT/BDOS icon.