Why call base.OnActionExecuting(filterContext);?
Solution 1:
Should I be always be calling the base methods after?
That will depend on the situation.
For example in authorization filters (deriving from AuthorizeAttribute
) if you call the base method then all the existing authorization logic built into ASP.NET MVC will be executed. If you don't call it, only your authorization logic will be applied.
As far as other standard action filters are concerned (deriving from ActionFilterAttribute
) all the OnActionExecuting
, OnActionExecuted
, OnResultExecuting
and OnResultExecuted
are defined as virtual but their body is empty, so it doesn't make any difference if you call or not the base method.
Solution 2:
I believe if you let Visual Studio automatically produce an overriding method by typing override
and selecting a method in intellisense and pressing tab, Visual Studio will automatically add base.MethodName()
in the method body.
If you don't need it, remove it. I've always removed it when creating my ActionFilter
s and haven't had a problem yet. The only time you shouldn't remove it is when you need the base method to be called.