Is "alien" offensive?
The term alien
is actually the technical term used by governments to describe someone who is not a citizen (of either the naturalized or natural born varieties). For example, one of the major immigration forms for the US is entitled "Application for Immigrant Visa and Alien Registration"
I would say it is not at all inappropriate, and any offense would really only be attributed to confusion between the two meanings.
As many people have said, "alien" is a term used by governments to refer to non-citizens. However I'm not sure how often that meaning is used outside of the immigration department. I'm sure for many English-speakers the word's first meaning is extraterrestrials. It certainly is for me.
Using this word sounds "marked" to me. That is, I'd wonder why a person was saying it unless they were a government worker. I'm not sure if there would be cause for offense, however.
Like many terms, it is not offensive in itself, but can be used in a distancing way that others, and so in different contexts it can be neutral, mildly rude, or strikingly offensive.
It is perhaps best considered as cold and technical. There are times when being cold and technical is appropriate, but there are also times when it is better not to be cold and technical in dealing with people's feelings. There are also times when people are pointedly cold and technical.