Problem understanding covariance contravariance with generics in C#
I can't understand why the following C# code doesn't compile.
As you can see, I have a static generic method Something with an IEnumerable<T>
parameter (and T
is constrained to be an IA
interface), and this parameter can't be implicitly converted to IEnumerable<IA>
.
What is the explanation? (I don't search for a workaround, just to understand why it doesn't work).
public interface IA { }
public interface IB : IA { }
public class CIA : IA { }
public class CIAD : CIA { }
public class CIB : IB { }
public class CIBD : CIB { }
public static class Test
{
public static IList<T> Something<T>(IEnumerable<T> foo) where T : IA
{
var bar = foo.ToList();
// All those calls are legal
Something2(new List<IA>());
Something2(new List<IB>());
Something2(new List<CIA>());
Something2(new List<CIAD>());
Something2(new List<CIB>());
Something2(new List<CIBD>());
Something2(bar.Cast<IA>());
// This call is illegal
Something2(bar);
return bar;
}
private static void Something2(IEnumerable<IA> foo)
{
}
}
Error I get in Something2(bar)
line:
Argument 1: cannot convert from 'System.Collections.Generic.List' to 'System.Collections.Generic.IEnumerable'
The error message is insufficiently informative, and that is my fault. Sorry about that.
The problem you are experiencing is a consequence of the fact that covariance only works on reference types.
You're probably saying "but IA
is a reference type" right now. Yes, it is. But you didn't say that T
is equal to IA
. You said that T
is a type which implements IA
, and a value type can implement an interface. Therefore we do not know whether covariance will work, and we disallow it.
If you want covariance to work you have to tell the compiler that the type parameter is a reference type with the class
constraint as well as the IA
interface constraint.
The error message really should say that the conversion is not possible because covariance requires a guarantee of reference-type-ness, since that is the fundamental problem.
I just wanted to complement Eric's excellent insider answer with a code example for those that may not be that familiar with generic constraints.
Change Something
's signature like this: The class
constraint has to come first.
public static IList<T> Something<T>(IEnumerable<T> foo) where T : class, IA