"Doubleclick to minimize enabled" prompt on Mac - how to disable it?

That popup is from the third-party tool BetterSnapTool.

This app provides its own functionality for the title bar double-click, which conflicts with the macOS functionality.

If you want to use the macOS functionality you enabled, disable the functionality in BetterSnapTool or uninstall the app entirely.