ASP.NET MVC - TempData - Good or bad practice
I'm using the AcceptVerbs method detailed in Scott Gu's Preview 5 blog post for dealing with form entries in ASP.NET MVC:
- User gets an empty form via GET
- User posts the filled in form via POST to the same Action
- The Action validates data, takes appropriate action, and redirects to a new view
So I don't have to use TempData. That said, I now have to add a 'confirm' step to this process, and it seems to require the use of TempData.
For some reason, I have an aversion to using TempData -- that it is something to be designed around.
Is this at all a valid concern, or am I making it up?
No need to have an aversion to TempData... But if not used correctly it could surely be an indication of poor design. If you are using RESTful URL's, TempData is a best practice for transfering messages from your POST Actions to your GET Actions. Consider this:
You have a form at URL Products/New. The form Posts to Products/Create, which validates the form and creates the Product, On Success the Controller redirects to URL Products/1 and on error would redirect back to products/New to display Error Messages.
Products/1 is just the standard GET action for the product, but we would like a message to display indicating the insert was a success. TempData is perfect for this. Add the message to TempData in the Post Controller and put some if logic in the view and your done.
On failure I've been adding the values entered in the formCollection and a collection of error Messages to TempData in the Post Action, and redirecting to the intial Action Prodcuts/New. I've added logic to the view to populate the form inputs with the previously entered values along with any error messages. Seems nice and clean to me!
I think you do well to hesitate before using TempData. TempData is stored in the session and this may have implications for you if:
- You don't use sessions on your site right now
- You have a system that needs to scale to high throughput, i.e. you'd prefer to avoid session state altogether
- You don't want to use cookies (I don't know how well MVC supports cookieless sessions right now)
If your site needs to have high availability, then there are additional considerations around applying session state but these are all solvable problems.
I kind of think of temp data as being a fire-and-forget mechanism for notifying the user. Its great to give them a reminder of something they recently did, but I'd also be hesitant to make it a required step in some user process. The reason being if they refresh the page, I believe it would be gone. Well I guess I'm also hesitant to use it as its not really well defined how reliable it is.
I wonder if the problem is that you're having the action redirect to another page before the confirm step. I wonder if instead after they first submit, you could do enough processing to generate the confirm dialog, then return the original page with the confirm question. Similar to how you might do validation, except the validation rule checks whether the confirmation step was performed (with the confirmation UI hidden until other validation passes).
I have a GetModel method which first checks for TempData["model"] and returns that. Otherwise GetModel loads the appropriate data from the database.
It saves an extra load from the database when I have an action that needs to return a different view that requires the same model data.