I think my drives are in the wrong bays on my iMac

Yes, the SSD is only getting 3 GigaBit Link Speed. And, you are correct with respect to having the ability for a third drive.

From the everymac's website:

The "Mid-2011" iMac models all support a single 3.5" hard drive and a second 2.5" SSD. As shipped, both the hard drive bay and SSD bay provided support for the 3 Gb/s Serial ATA 2.0 standard. However, as first discovered by site sponsor Other World Computing, the iMac EFI Update 1.6, released two days later, quietly provided faster 6 Gb/s Serial ATA 3.0 support for both of these connectors (but not the optical drive connector).

There is a video titled 2011 21.5-inch iMac HDD Upgrade.

There is also a video titled 2011 27-inch iMac SSD Bay Drive Install.

Answers to Your Three Questions

1. Did the guy put the HDD in the SATA3 slot and the SSD in the SATA2 slot?

   It would appear the new HDD replaced the old HDD. The HDD cable should have included special hardware so the fans would work correctly. For example, see the OWC In-line Digital Thermal Sensor for iMac 2011 Hard Drive Upgrade. The SDD was probably replaced the optical drive and is connect to the logic board where the optical drive was connected.

   I am typing this answer on a iMac (21.5-inch, Mid 2011). Below are my images, which you can compare to your images. This Mac has the original HDD and optical drive.

   Optical Drive

   

   HDD

   

2. Did he unnecessarily remove the optical drive when he could have used an available bay?

   According to OWC, the answer would be yes.

3. Would switching them so that the SSD (boot drive) is connected to the SATA3 controller produce any sort of noticeable difference?

   Yes. Do the math. According to the product flyer, the sequential read speed is 530 MB/s. Multiply by 8 to get bits per second and you get 4.24 Gb/s. This is faster the the link speed of 3 Gb/s.

   Although, switching may not be a simple task, if the cabling included additional hardware to measure the temperature of the new HDD drive. You probably would be better off using the third bay designed for a SSD.