Python: Function always returns None
I have some Python code that basically looks like this:
my_start_list = ...
def process ( my_list ):
#do some stuff
if len(my_list) > 1:
process(my_list)
else:
print(my_list)
return my_list
print(process(my_start_list))
The strange thing is: print(my_list)
prints out the correct content. However, the second print statement printing the return value of the function always prints None
.
Even if I replace the normal return
statement with return("abc")
it is still None
.
As the content of the variable seems to be correct one line before the return statement, I don't know where to start debugging. Are there any common problems that may cause this?
Here's what happening:
- You call
process(my_start_list)
. - In the function, the
if
block is executed iflen(my_list) > 1
, and there are no return statement there. Now, since theelse
has not been executed and since that is the only place where you have the return clause, you return the default which isNone
. - If you have 0 or 1 elements in your list, you return that list.
To fix this, you'd want to return the list returned by process(my_list)
.
That is:
def process(my_list):
# do some stuff
...
if len(my_list) > 1:
return process(my_list)
else:
print(my_list)
return my_list
You're only returning the list when you have 1 or 0 elements in it (the base case). You need a return statement in the first block as well, where you make the recursive call, or else you drill down to the base case, return the length-1 list to the next level, and then return None
the rest of the way up. So what you want looks like this, instead:
def process(my_list):
# Do some stuff.
if len(my_list) > 1:
return process(my_list) #If you don't return this result, you return None
else:
print(my_list)
return my_list
Now every case (not just the base case) has a return value, so that return value will propagate all the way back up to your initial call.
You call process
recursively but never ignore it's return value when you do. Add a return
statement to pass on the return value::
def process ( my_list ):
#do some stuff
if len(my_list) > 1:
return process(my_list)
else:
print(my_list)
return my_list
Now, when len(my_list) > 1
is True
, you actually pass on the return value of the recursive call.
As others have pointed out, you are missing a return
statement.
I personally would turn that tail recursion into iteration:
def process(my_list):
while True:
# do some stuff
if len(my_list) <= 1:
return my_list
I think this makes the intent a little clearer, and also avoids some pitfalls associated with tail recursion.